1   package test.net.sourceforge.pmd.rules.design;
2   
3   import net.sourceforge.pmd.PMD;
4   import net.sourceforge.pmd.Rule;
5   import net.sourceforge.pmd.RuleSetNotFoundException;
6   import test.net.sourceforge.pmd.testframework.SimpleAggregatorTst;
7   import test.net.sourceforge.pmd.testframework.TestDescriptor;
8   
9   public class PositionLiteralsFirstInComparisonsTest extends SimpleAggregatorTst {
10  
11      private Rule rule;
12  
13      public void setUp() throws RuleSetNotFoundException {
14          rule = findRule("design", "PositionLiteralsFirstInComparisons");
15      }
16  
17      public void testAll() {
18          runTests(new TestDescriptor[]{
19              new TestDescriptor(TEST1, "ok, literal comes first", 0, rule),
20              new TestDescriptor(TEST2, "bad, literal comes last", 1, rule),
21              new TestDescriptor(TEST3, "ok", 0, rule),
22          });
23      }
24  
25      private static final String TEST1 =
26              "public class Foo {" + PMD.EOL +
27              " boolean bar(String x) {" + PMD.EOL +
28              "  return \"2\".equals(x);" + PMD.EOL +
29              " }" + PMD.EOL +
30              "}";
31  
32      private static final String TEST2 =
33              "public class Foo {" + PMD.EOL +
34              " boolean bar(String x) {" + PMD.EOL +
35              "  return x.equals(\"2\");" + PMD.EOL +
36              " }" + PMD.EOL +
37              "}";
38  
39      private static final String TEST3 =
40              "public class Foo {" + PMD.EOL +
41              " void bar() {" + PMD.EOL +
42              "  if((str == null) || (str.equals(\"\"))) {" + PMD.EOL +
43              "   str = \"snafu\";" + PMD.EOL +
44              "  }" + PMD.EOL +
45              " }" + PMD.EOL +
46              "}";
47  
48  }